Skip to content

embeded_image_path vs embedded_image_path #398

@pstoeckle

Description

@pstoeckle

Background

I had the follow snippet in my project

from qrcode import QRCode
from qrcode import constants
from qrcode.image.styledpil import StyledPilImage
qr_code = QRCode(error_correction=constants.ERROR_CORRECT_H)
img_3 = qr_code.make_image(
    image_factory=StyledPilImage, embeded_image_path=embedded_image
)

Furthermore, I use the typos to find and fix typos in my Projects.

Problem

typos changed embeded_image_path to embedded_image_path.
The qrcode generation did NOT fail, but produced an QR with no embedded image.
The problem is that StyledPilImage is looking for embeded_image_path, i.e., there is a typo in the keyword parameter.

Potential Solution(s)

  1. Fix the typo in StyledPilImage, i.e., here
  2. Show a warning when someone is passing embedded_image_path as keyword parameter to StyledPilImage
  3. Throw an exception if someone is passing embedded_image_path as keyword parameter

WDYT?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions