fixes customizer logic in the GsonGrpcJsonMarshallerBuilder#6146
Merged
fixes customizer logic in the GsonGrpcJsonMarshallerBuilder#6146
Conversation
JsonFormat.Parser and JsonFormat.Printer classes are immutable and calling any method in customizer creates new object. Because of that result of the customer is ignored so we need a way to use new object created in the customizer. Replaces Consumer<T> with the Function<T, T> customizer which returns customized object.
Contributor
Contributor
|
Hi, @AnyRoad! Thanks for the PR!
|
…ilder' into fix_gson_grpc_json_marshaller_builder
Contributor
Author
Hi @minwoox ! |
trustin
reviewed
Mar 14, 2025
grpc/src/main/java/com/linecorp/armeria/common/grpc/GsonGrpcJsonMarshallerBuilder.java
Show resolved
Hide resolved
grpc/src/main/java/com/linecorp/armeria/common/grpc/GsonGrpcJsonMarshallerBuilder.java
Show resolved
Hide resolved
trustin
approved these changes
Mar 17, 2025
grpc/src/main/java/com/linecorp/armeria/common/grpc/GsonGrpcJsonMarshallerBuilder.java
Outdated
Show resolved
Hide resolved
grpc/src/main/java/com/linecorp/armeria/common/grpc/GsonGrpcJsonMarshallerBuilder.java
Outdated
Show resolved
Hide resolved
…onMarshallerBuilder.java
…onMarshallerBuilder.java
jrhee17
approved these changes
Mar 18, 2025
minwoox
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Modifications:
Result: