Skip to content

Conversation

@icepeppermint
Copy link
Contributor

Motivation:

I found that the VirtualHost#normalizeHostnamePattern method was performing unnecessary operations.

Modifications:

  • Moved the code to remove the wildcard from hostnamePattern inside the if then scope.

Result:

  • I expect that operations to be performed only if hostnamePattern is not a wildcard.

@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.61%. Comparing base (8150425) to head (756e1e0).
Report is 71 commits behind head on main.

Files with missing lines Patch % Lines
.../java/com/linecorp/armeria/server/VirtualHost.java 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6208      +/-   ##
============================================
+ Coverage     74.46%   74.61%   +0.15%     
- Complexity    22234    22474     +240     
============================================
  Files          1963     1972       +9     
  Lines         82437    82993     +556     
  Branches      10764    10799      +35     
============================================
+ Hits          61385    61929     +544     
- Misses        15918    15923       +5     
- Partials       5134     5141       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ikhoon ikhoon added the cleanup label Apr 17, 2025
@ikhoon ikhoon added this to the 1.33.0 milestone Apr 17, 2025
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@jrhee17 jrhee17 merged commit c3b22a1 into line:main May 12, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants