Conversation
WalkthroughRemoved Docker-related entries from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
1b98ca3 to
45f29f7
Compare
|
Q. I just changed client binary name to use underscore (ex. |
minwoox
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Client binary name is changed. It uses underscore now.
What's the rationale behind this, by the way?
I just read this. 👍 |
|
|
||
| COPY --chmod=755 \ | ||
| build/dist/bin/native/dogma.linux_${TARGETARCH} \ | ||
| "$CENTRALDOGMA_HOME"/bin/native/ |
Motivation:
Currently docker image has all client binaries inside, also copied twice under
bin/*andbin/native/*. Only single client binary file is enough. Image below is layer info insideghcr.io/line/centraldogma:0.77.2(used dive)Also linux/arm64 image doesn't have linux/arm64 client binary.
Modification:
linux/arm64binary is available.dogma.linux-amd64->dogma.linux_amd64)Result:
docker inspect)Summary by CodeRabbit