Conversation
WalkthroughBump Armeria version from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
============================================
+ Coverage 70.68% 70.70% +0.02%
- Complexity 4764 4776 +12
============================================
Files 475 475
Lines 19633 19681 +48
Branches 2158 2176 +18
============================================
+ Hits 13877 13916 +39
- Misses 4583 4585 +2
- Partials 1173 1180 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/publish-release.yml (2)
11-16: Consider explicit GITHUB_TOKEN permissions for release upload.The upload-release step typically needs contents: write. Add job-level permissions to prevent surprises if org defaults are restrictive.
Apply:
jobs: publish: name: Publish final artifacts if: github.repository == 'line/centraldogma' runs-on: ubuntu-latest + permissions: + contents: write
17-28: Optional: bump action versions when convenient.Not required for this PR, but consider upgrading to the latest majors for security and fixes:
- actions/checkout@v4
- actions/setup-java@v4
- gradle/gradle-build-action@v3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/publish-release.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (16)
- GitHub Check: build-windows-latest-jdk-21
- GitHub Check: build-ubuntu-latest-jdk-17-min-java-11
- GitHub Check: build-ubuntu-latest-jdk-21-snapshot
- GitHub Check: build-ubuntu-latest-jdk-17-coverage
- GitHub Check: build-ubuntu-latest-jdk-11
- GitHub Check: build-macos-latest-jdk-21
- GitHub Check: flaky-tests
- GitHub Check: lint
- GitHub Check: build-ubuntu-latest-jdk-17-min-java-11
- GitHub Check: build-ubuntu-latest-jdk-17-coverage
- GitHub Check: build-ubuntu-latest-jdk-21-snapshot
- GitHub Check: build-ubuntu-latest-jdk-11
- GitHub Check: build-macos-latest-jdk-21
- GitHub Check: build-windows-latest-jdk-21
- GitHub Check: lint
- GitHub Check: flaky-tests
🔇 Additional comments (1)
.github/workflows/publish-release.yml (1)
39-40: Confirm MAVEN_CENTRAL_USERNAME and MAVEN_CENTRAL_PASSWORD are definedTried to list secrets with gh but received "HTTP 403: Resource not accessible by integration" and cannot verify. The env mapping to ORG_GRADLE_PROJECT_ossrhUsername/ossrhPassword in .github/workflows/publish-release.yml (lines 39–40) is correct — ensure those two secrets exist at the repo or org level to avoid release failures.
Summary by CodeRabbit