Skip to content

Update Armeria version to 1.33.3#1180

Merged
minwoox merged 2 commits intomainfrom
update-armeria-version
Sep 23, 2025
Merged

Update Armeria version to 1.33.3#1180
minwoox merged 2 commits intomainfrom
update-armeria-version

Conversation

@armerian
Copy link
Collaborator

@armerian armerian commented Sep 17, 2025

Summary by CodeRabbit

  • Chores
    • Upgraded a core networking library to the latest patch release, bringing upstream bug fixes and minor performance/stability improvements.
    • Updated release publishing configuration to use revised credentials references for artifact publication; no user-facing behavior changes.

@coderabbitai
Copy link

coderabbitai bot commented Sep 17, 2025

Walkthrough

Bump Armeria version from 1.33.2 to 1.33.3 in dependencies.toml and update the GitHub Actions publish-release workflow to read Gradle publishing secrets from MAVEN_CENTRAL_USERNAME / MAVEN_CENTRAL_PASSWORD (secret names only; env var keys unchanged).

Changes

Cohort / File(s) Summary
Dependency version bump
dependencies.toml
Update [versions].armeria from 1.33.2 to 1.33.3.
Publish workflow secret rename
.github/workflows/publish-release.yml
Change secret references from OSSRH_USER_NAME/OSSRH_PASSWORD to MAVEN_CENTRAL_USERNAME/MAVEN_CENTRAL_PASSWORD for Gradle publishing credentials; environment variable keys (ORG_GRADLE_PROJECT_ossrhUsername / ORG_GRADLE_PROJECT_ossrhPassword) remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

dependencies

Suggested reviewers

  • trustin
  • jrhee17

Poem

Hop, I nibble a version carrot bright,
One small hop and the numbers light.
Secrets swapped where workflows tread,
Tiny changes, safely spread.
— a rabbit’s cheer for code well-fed 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Update Armeria version to 1.33.3" is concise and accurately describes the primary change in the changeset (the Armeria version bump in dependencies.toml). While the PR also modifies workflow secret references, the title captures the main intent and is clear enough for teammates scanning the project history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-armeria-version

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.70%. Comparing base (ca4e9d7) to head (5af0d5f).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1180      +/-   ##
============================================
+ Coverage     70.68%   70.70%   +0.02%     
- Complexity     4764     4776      +12     
============================================
  Files           475      475              
  Lines         19633    19681      +48     
  Branches       2158     2176      +18     
============================================
+ Hits          13877    13916      +39     
- Misses         4583     4585       +2     
- Partials       1173     1180       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@minwoox minwoox modified the milestones: 0.78.0, 0.77.3 Sep 19, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/publish-release.yml (2)

11-16: Consider explicit GITHUB_TOKEN permissions for release upload.

The upload-release step typically needs contents: write. Add job-level permissions to prevent surprises if org defaults are restrictive.

Apply:

 jobs:
   publish:
     name: Publish final artifacts
     if: github.repository == 'line/centraldogma'
     runs-on: ubuntu-latest
+    permissions:
+      contents: write

17-28: Optional: bump action versions when convenient.

Not required for this PR, but consider upgrading to the latest majors for security and fixes:

  • actions/checkout@v4
  • actions/setup-java@v4
  • gradle/gradle-build-action@v3
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5af0d5f and 2ff2699.

📒 Files selected for processing (1)
  • .github/workflows/publish-release.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (16)
  • GitHub Check: build-windows-latest-jdk-21
  • GitHub Check: build-ubuntu-latest-jdk-17-min-java-11
  • GitHub Check: build-ubuntu-latest-jdk-21-snapshot
  • GitHub Check: build-ubuntu-latest-jdk-17-coverage
  • GitHub Check: build-ubuntu-latest-jdk-11
  • GitHub Check: build-macos-latest-jdk-21
  • GitHub Check: flaky-tests
  • GitHub Check: lint
  • GitHub Check: build-ubuntu-latest-jdk-17-min-java-11
  • GitHub Check: build-ubuntu-latest-jdk-17-coverage
  • GitHub Check: build-ubuntu-latest-jdk-21-snapshot
  • GitHub Check: build-ubuntu-latest-jdk-11
  • GitHub Check: build-macos-latest-jdk-21
  • GitHub Check: build-windows-latest-jdk-21
  • GitHub Check: lint
  • GitHub Check: flaky-tests
🔇 Additional comments (1)
.github/workflows/publish-release.yml (1)

39-40: Confirm MAVEN_CENTRAL_USERNAME and MAVEN_CENTRAL_PASSWORD are defined

Tried to list secrets with gh but received "HTTP 403: Resource not accessible by integration" and cannot verify. The env mapping to ORG_GRADLE_PROJECT_ossrhUsername/ossrhPassword in .github/workflows/publish-release.yml (lines 39–40) is correct — ensure those two secrets exist at the repo or org level to avoid release failures.

@minwoox minwoox merged commit cc4e3e2 into main Sep 23, 2025
18 checks passed
@minwoox minwoox deleted the update-armeria-version branch September 23, 2025 06:25
@coderabbitai coderabbitai bot mentioned this pull request Jan 7, 2026
@coderabbitai coderabbitai bot mentioned this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants