Call processingReturn and register processingCompletion even if task fails to process exceptionally #271
Merged
ocadaruma merged 1 commit intoline:masterfrom Mar 26, 2026
Conversation
m50d
approved these changes
Mar 16, 2026
mauhiz
approved these changes
Mar 16, 2026
ocadaruma
approved these changes
Mar 26, 2026
Member
ocadaruma
left a comment
ocadaruma
left a comment
There was a problem hiding this comment.
Sorry for the delay, LGTM.
Thank you!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The tracing handle does not seem to handle the exceptional path if an exception is thrown from processing, which contradicts the handler's promises. It might result in trace leaks.
What
This change is to move processingReturn to be called, and processingCompletion to be registered around the finally block, to guarantee no trace leak even in the exceptional path.