Skip to content

Prevent script injection in fork PR comment workflow#120

Merged
Yang-33 merged 1 commit intomainfrom
use-var-before-using-shell
Mar 24, 2026
Merged

Prevent script injection in fork PR comment workflow#120
Yang-33 merged 1 commit intomainfrom
use-var-before-using-shell

Conversation

@Yang-33
Copy link
Copy Markdown
Contributor

@Yang-33 Yang-33 commented Mar 16, 2026

At least for now, injection based on user names may not be possible, and this workflow shouldn't allow dangerous actions. However, applying this as a precaution against future incidents is a good idea. also we use pull_request_target so external user can't fix this workflow until merging.

@github-actions
Copy link
Copy Markdown

JAVA

You can check generated code in java

Check the diff here

@github-actions
Copy link
Copy Markdown

PHP

You can check generated code in php

Check the diff here

@github-actions
Copy link
Copy Markdown

NODEJS

You can check generated code in nodejs

Check the diff here

@github-actions
Copy link
Copy Markdown

PYTHON

You can check generated code in python

Check the diff here

@github-actions
Copy link
Copy Markdown

GO

You can check generated code in go

Check the diff here

@github-actions
Copy link
Copy Markdown

RUBY

You can check generated code in ruby

Check the diff here

@Yang-33 Yang-33 requested a review from a team March 16, 2026 08:01
@Yang-33 Yang-33 enabled auto-merge March 19, 2026 02:00
@Yang-33 Yang-33 added this pull request to the merge queue Mar 24, 2026
@Yang-33 Yang-33 removed this pull request from the merge queue due to a manual request Mar 24, 2026
@Yang-33 Yang-33 merged commit c601805 into main Mar 24, 2026
24 checks passed
@Yang-33 Yang-33 deleted the use-var-before-using-shell branch March 24, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants