Remove 'authorization' field from the retrieve Shard API#576
Merged
vincent-olivert-riera merged 1 commit intoline:masterfrom Mar 13, 2025
Merged
Remove 'authorization' field from the retrieve Shard API#576vincent-olivert-riera merged 1 commit intoline:masterfrom
vincent-olivert-riera merged 1 commit intoline:masterfrom
Conversation
vincent-olivert-riera
requested changes
Mar 13, 2025
Contributor
vincent-olivert-riera
left a comment
vincent-olivert-riera
left a comment
There was a problem hiding this comment.
@hoangpn , please rebase your branch on master.
For security reason, we should not return token data of to users through the retrieve Shard API.
hoangpn
force-pushed
the
chore/hide_shard_token
branch
from
566874a to
ca0f3af
Compare
vincent-olivert-riera
approved these changes
Mar 13, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For security reason, we should not return token data of to users through the retrieve Shard API.
BEFORE:
AFTER:
