Disengage Farm Update from Project#594
Merged
vincent-olivert-riera merged 5 commits intoline:masterfrom May 29, 2025
Merged
Conversation
We made some changes to the Farm Detail Page to improve UI/UX. - Move the Delete button to the page header from the Hosts table using a template similar to the Service detail page. - Shorten the Hosts table name. - Make the Delete host button smaller to fit within a single row in the table.
We added an 'Edit Farm' button on the Farm Detail Page, enabling users to update all the farm details from this page.
We changed the farm_form.html of the Farm Update page to improve UI/UX and to align it with other forms, such as the Service and Project Update pages.
hoangpn
force-pushed
the
feature/disengage_farm_update_from_project
branch
from
708e53e to
eb2d548
Compare
In Promgen, Farms are standalone objects. They just happen to be linkable to Projects. Therefore, we have disengaged actions such as Edit Farm, Delete Farm, Add Hosts, and Delete Host from the Project Detail Page. Now, these actions can only be performed through the Farm Detail Page. After successfully completing these actions, users will also be redirected to the Farm Detail Page instead of the Project Detail Page as before. For the same reason, the breadcrumbs of some forms have been changed to no longer display the project name. These changes also fixed a bug related to accessing the Farm Update Page or Host Register Page of a Farm that isn't linked to any Project.
We have created a separate template named farm_register.html specifically for the case of creating a new Farm. Currently, to avoid creating a new Farm not linked to any Project, a Farm can only be created through the Farm Register button on the Project Detail Page. To facilitate the creation of a new Farm, we allow users to enter hosts at the same time when creating the Farm. The old template will be renamed to farm_update.html to match its intended use.
hoangpn
force-pushed
the
feature/disengage_farm_update_from_project
branch
from
eb2d548 to
2710ca0
Compare
Contributor
Author
|
I've force pushed to fix a minor bug on UI found when I do self-testing. |
vincent-olivert-riera
approved these changes
May 29, 2025
Contributor
vincent-olivert-riera
left a comment
vincent-olivert-riera
left a comment
There was a problem hiding this comment.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Farms are standalone objects. They just happen to be linkable to Projects. Therefore, I made some changes on Promgen UI to disengage Farm Update from Project.
The Project Detail Page:
Farm editable:
AS-IS:
TO-BE:
Farm non-editable:
AS-IS:
TO-BE:
The Farm Detail Page:
Farm editable:
AS-IS:
TO-BE:
Farm non-editable:
AS-IS:
TO-BE:
The Farm Register page:
AS-IS:
TO-BE:
The Farm Update page:
AS-IS:
TO-BE: