Skip to content

Add 'Token' panel to UI#596

Merged
vincent-olivert-riera merged 1 commit intoline:masterfrom
hoangpn:feature/user_token
Jun 3, 2025
Merged

Add 'Token' panel to UI#596
vincent-olivert-riera merged 1 commit intoline:masterfrom
hoangpn:feature/user_token

Conversation

@hoangpn
Copy link
Contributor

@hoangpn hoangpn commented May 27, 2025

When accessing APIs created by Promgen's Django REST Framework, users will need a Token for authentication. We have added a new panel on the Profile page that allows users to create and manage their own tokens.
image
image

@hoangpn hoangpn requested a review from a team as a code owner May 27, 2025 04:15
Copy link
Contributor

@vincent-olivert-riera vincent-olivert-riera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes. Overall looks very good.

@hoangpn
Copy link
Contributor Author

hoangpn commented Jun 2, 2025

@vincent-olivert-riera
Thank you so much for your suggestions. I've push the fixup commit. Please review it again. 🙇
p/s: The conflicts will be resolved in the final review.

@vincent-olivert-riera
Copy link
Contributor

@vincent-olivert-riera Thank you so much for your suggestions. I've push the fixup commit. Please review it again. 🙇 p/s: The conflicts will be resolved in the final review.

You could have used the "Commit suggestion" button. It would have been easier to review for me, and also, some mistakes that I found on your fixup commit wouldn't be there :)

@hoangpn
Copy link
Contributor Author

hoangpn commented Jun 3, 2025

@vincent-olivert-riera Thank you so much for your suggestions. I've push the fixup commit. Please review it again. 🙇 p/s: The conflicts will be resolved in the final review.

You could have used the "Commit suggestion" button. It would have been easier to review for me, and also, some mistakes that I found on your fixup commit wouldn't be there :)

Thank you! I don't know about this feature yet. I'll try it now. 😄

@hoangpn
Copy link
Contributor Author

hoangpn commented Jun 3, 2025

@vincent-olivert-riera Thank you so much for your suggestions. I've push the fixup commit. Please review it again. 🙇 p/s: The conflicts will be resolved in the final review.

You could have used the "Commit suggestion" button. It would have been easier to review for me, and also, some mistakes that I found on your fixup commit wouldn't be there :)

Thank you! I don't know about this feature yet. I'll try it now. 😄

I did it. Is it fine from your view? 👀

@vincent-olivert-riera
Copy link
Contributor

vincent-olivert-riera commented Jun 3, 2025

I did it. Is it fine from your view? 👀

Yes, perfect.

Please rebase the branch and squash all the necessary commits. After that I will have a last look at it and hopefully approve it and merge it. 👍

@hoangpn hoangpn force-pushed the feature/user_token branch from 7b85c09 to 9708c6f Compare June 3, 2025 07:48
When accessing APIs created by Promgen's Django REST Framework, users will need a Token
for authentication. We have added a new panel on the Profile page that allows users to
create and manage their own tokens.
@hoangpn hoangpn force-pushed the feature/user_token branch from 9708c6f to a296f1f Compare June 3, 2025 07:50
@vincent-olivert-riera vincent-olivert-riera merged commit 6e11ab4 into line:master Jun 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants