Not provide query results when testing Rule#614
Merged
vincent-olivert-riera merged 1 commit intoline:masterfrom Jun 17, 2025
Merged
Not provide query results when testing Rule#614vincent-olivert-riera merged 1 commit intoline:masterfrom
vincent-olivert-riera merged 1 commit intoline:masterfrom
Conversation
Contributor
|
@hoangpn , thanks for this. I have one request to make. In the case of a "Not firing" alert rule, I think it does not make sense to show a table with Could you please make that change? 🙇 |
vincent-olivert-riera
approved these changes
Jun 17, 2025
Contributor
vincent-olivert-riera
left a comment
vincent-olivert-riera
left a comment
There was a problem hiding this comment.
Looks good to me.
Could you please rebase on master and squash all the fixups?
hoangpn
force-pushed
the
feature/test_query
branch
from
d92f70d to
a2b01ce
Compare
From the Rule's edit page, users can write any query and execute with the test button. After that, the results are presented on the screen. The query is executed on all data sources, and for that Promgen provides the basic auth credentials configured in for each data source. This capability led to a potential security issue where users can run any query anonymously. Therefore, we want to stop providing the query results to the user, and instead, just say if the rule would fire or not.
hoangpn
force-pushed
the
feature/test_query
branch
from
a2b01ce to
a983918
Compare
Contributor
Author
|
@vincent-olivert-riera Thank you so much. |
vincent-olivert-riera
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the Rule's edit page, users can write any query and execute with the test button. After that, the results are presented on the screen. The query is executed on all data sources, and for that Promgen provides the basic auth credentials configured in for each data source. This capability led to a potential security issue where users can run any query anonymously.
Therefore, we want to stop providing the query results to the user, and instead, just say if the rule would fire or not.
Not firing:
AS-IS:
TO-BE:
Firing:
AS-IS:
TO-BE: