Make notifier's filters not editable if 'show_edit' is false#616
Merged
vincent-olivert-riera merged 1 commit intoline:masterfrom Jun 20, 2025
Merged
Conversation
hoangpn
force-pushed
the
feature/make_notifier_filter_not_editable
branch
from
57a0f1c to
7b5f178
Compare
Currently, when displaying the notifier list, the Actions column will not be shown if show_edit is false. However, the filter column is still displayed along with the Add and Remove buttons when show_edit is false. For instance, when we display the Service notifiers from the Project detail page, the Action column is hidden by using the show_edit variable. However, even if the Actions column is hidden because the users are not supposed to edit those notifiers, they are still able to add filters to it, which is an edit action on the notifier. We have changed it to only display the filters as labels and not show any actionable buttons so that the users are not supposed to add, edit or remove filters of a notifier if the value of 'show_edit' is false.
hoangpn
force-pushed
the
feature/make_notifier_filter_not_editable
branch
from
7b5f178 to
02eeebe
Compare
vincent-olivert-riera
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when displaying the notifier list, the Actions column will not be shown if show_edit is false. However, the filter column is still displayed along with the Add and Remove buttons when show_edit is false. For instance, when we display the Service notifiers from the Project detail page, the Action column is hidden by using the show_edit variable. However, even if the Actions column is hidden because the users are not supposed to edit those notifiers, they are still able to add filters to it, which is an edit action on the notifier.
We have changed it to only display the filters as labels and not show any actionable buttons so that the users are not supposed to add, edit or remove filters of a notifier if the value of 'show_edit' is false.
AS-IS:
TO-BE:
