Sort the Farm's sources on the Project Detail page#618
Merged
vincent-olivert-riera merged 1 commit intoline:masterfrom Jun 25, 2025
Merged
Sort the Farm's sources on the Project Detail page#618vincent-olivert-riera merged 1 commit intoline:masterfrom
vincent-olivert-riera merged 1 commit intoline:masterfrom
Conversation
vincent-olivert-riera
requested changes
Jun 24, 2025
Contributor
vincent-olivert-riera
left a comment
vincent-olivert-riera
left a comment
There was a problem hiding this comment.
Works fine, but the code is a little bit too magic and I think it requires explanation.
vincent-olivert-riera
requested changes
Jun 25, 2025
Contributor
vincent-olivert-riera
left a comment
vincent-olivert-riera
left a comment
There was a problem hiding this comment.
@hoangpn , excellent.
I made one request to fix a mistake made by me.
Please, address that, and the next time you push, please rebase on master and squash all the fixups.
It will be ready to approve and merge.
hoangpn
force-pushed
the
feature/sort_farm_source
branch
from
2da5607 to
55c964b
Compare
vincent-olivert-riera
approved these changes
Jun 25, 2025
We sorted the Farm's sources to ensure that Local Farms always appear first, followed by Remote Farms on the UI when users choose a source to link a Farm to a Project.
vincent-olivert-riera
force-pushed
the
feature/sort_farm_source
branch
from
55c964b to
400a35d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We sorted the Farm's sources to ensure that Local Farms always appear first, followed by Remote Farms on the UI when users choose a source to link a Farm to a Project.