Support change member's role on UI#634
Merged
vincent-olivert-riera merged 2 commits intoline:masterfrom Aug 14, 2025
Merged
Conversation
vincent-olivert-riera
requested changes
Aug 14, 2025
vincent-olivert-riera
requested changes
Aug 14, 2025
| {{ permission_form.permission }} | ||
| <button class="btn btn-primary btn-xs">Change</button> | ||
| </form> | ||
| </div> |
Contributor
There was a problem hiding this comment.
@hoangpn , one more thing. The owner of an object should always have admin permissions, and you cannot change its permissions unless you change the object's ownership.
Therefore, this cog icon and the whole collapsed form should not be included if the user is the owner of the object.
{% if not owner %}
Display all of that
{% endif %}
hoangpn
force-pushed
the
feature/change_member_role
branch
2 times, most recently
from
adda672 to
7b35557
Compare
Since users cannot remove the owner's permission without transferring ownership, we have removed the button for this action from the UI.
Currently, the only way to change a member's role is to delete the member and add them again with the desired role. From a UX perspective, this is somewhat inconvenient. Therefore, we have added a small button next to each member's role label in the member list table to quickly support changing the member's role.
hoangpn
force-pushed
the
feature/change_member_role
branch
from
7b35557 to
5f3fa23
Compare
vincent-olivert-riera
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the only way to change a member's role is to delete the member and add them again with the desired role. From a UX perspective, this is somewhat inconvenient. Therefore, we have added a small button next to each member's role label in the member list table to quickly support changing the member's role.
And since users cannot remove the owner's permission without transferring
ownership, we also have removed the button for this action from the UI.