Merged
Conversation
vincent-olivert-riera
requested changes
Sep 4, 2025
Contributor
vincent-olivert-riera
left a comment
vincent-olivert-riera
left a comment
There was a problem hiding this comment.
@hoangpn , review done.
vincent-olivert-riera
requested changes
Sep 5, 2025
Contributor
vincent-olivert-riera
left a comment
vincent-olivert-riera
left a comment
There was a problem hiding this comment.
Thanks for all the fixups. It now looks great.
I have only one last (very minor) request; please have a look.
hoangpn
force-pushed
the
feature/group
branch
from
2558cd2 to
af2e8a2
Compare
vincent-olivert-riera
requested changes
Sep 5, 2025
We have created a proxy model Group for Django's auth.Group model. A Group is a collection of multiple users, where each user will have one of two roles: Admin or Member.
hoangpn
force-pushed
the
feature/group
branch
from
1980c88 to
624c09e
Compare
We have made changes to the Promgen Web to help users interact with the features of the Group model. Users can now access the list of Groups through a new menu at the top bar. They can also access the Group detail page and perform actions such as managing the member list or viewing the edit history of the Group there.
hoangpn
force-pushed
the
feature/group
branch
from
624c09e to
537931e
Compare
vincent-olivert-riera
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the Group model, which is a collection of multiple users. Each user will have one of two roles: Admin or Member.
User can create group and manage member on Promgen Web.