Bugfix/project owner lost admin perm#661
Merged
vincent-olivert-riera merged 2 commits intoline:masterfrom Oct 29, 2025
Merged
Conversation
vincent-olivert-riera
requested changes
Oct 28, 2025
Contributor
vincent-olivert-riera
left a comment
vincent-olivert-riera
left a comment
There was a problem hiding this comment.
Overall looks good, but please take a look at the comments. 🙇
Contributor
|
@hoangpn , looks good. Please squash the fixups. |
hoangpn
force-pushed
the
bugfix/project_owner_lost_admin_perm
branch
from
cf80363 to
d8d9ec1
Compare
In Promgen, there's currently an issue where a project's owner might not have admin permission on that project. This happens when a user, A, is both the owner of a project and has permission on its parent service. If another user, B, tries to remove user A's permission from the service and checks the "Remove permissions on child projects" option, user A will lose admin permission on the project, even though they remain the owner. This situation goes against our Promgen rule, which ensures that an object's owner always has admin permission on it. However, actions on a service should have a greater impact than on its child projects. So, we've decided to respect user B's action in this case. Therefore, to resolve this issue, the removal of permissions will proceed successfully, and the project's ownership will be transferred to the owner of the parent service. A warning also was added to notice user about the change of the owner.
At commit 7222e82, we fixed the bug where the project's owner lost admin permission. We added a migration file to re-assign the owner to projects which have this data inconsistency. The ownership of the project is transferred from the current owner to the service's owner, and also the admin permission is granted to these new owners.
hoangpn
force-pushed
the
bugfix/project_owner_lost_admin_perm
branch
from
d8d9ec1 to
a9bd809
Compare
vincent-olivert-riera
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.