Add Audit Logs when assigning or removing permission for a Group#662
Merged
vincent-olivert-riera merged 1 commit intoline:masterfrom Oct 28, 2025
Conversation
We introduced a feature that allows users to assign or remove permission for a Group. Recording these actions as Audit Logs would be useful for users. Therefore, we have linked the GroupObjectPermission model to the create_log and delete_log functions using the post_save and post_delete signals to generate audit logs when permissions are assigned to or removed from a group. However, the post_delete signal will be temporarily disconnected when migration file number 0033 is executed. In this scenario, Promgen removes permissions automatically, so Audit Logs are not needed.
vincent-olivert-riera
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduced a feature that allows users to assign or remove permission for a Group. Recording these actions as Audit Logs would be useful for users. Therefore, we have linked the GroupObjectPermission model to the create_log and delete_log functions using the post_save and post_delete signals to generate audit logs when permissions are assigned to or removed from a group.
However, the post_delete signal will be temporarily disconnected when migration file number 0033 is executed. In this scenario, Promgen removes permissions automatically, so Audit Logs are not needed.