Automatically set created_by field when creating new Silence#688
Merged
vincent-olivert-riera merged 1 commit intoline:masterfrom Jan 30, 2026
Merged
Conversation
Contributor
vincent-olivert-riera
left a comment
There was a problem hiding this comment.
Looks good to me, but please rebase this branch on master when you have time.
97f107c to
8a927a0
Compare
Contributor
Author
Thank you for your time. I have rebase it on master branch. 🙇 |
Currently, when a user creates a new Silence, they can enter anything into the created_by field. If left empty, the user's email will automatically be filled in. In cases where the user doesn't have an email, the value "Promgen" will be set. This can cause ambiguity and make tracking difficult. Therefore, we have removed the ability to input values for created_by and always set the user's username instead to ensure accountability when creating a Silence.
8a927a0 to
71d903e
Compare
vincent-olivert-riera
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a user creates a new Silence, they can enter anything into the created_by field. If left empty, the user's email will automatically be filled in. In cases where the user doesn't have an email, the value "Promgen" will be set. This can cause ambiguity and make tracking difficult.
Therefore, we have removed the ability to input values for created_by and always set the user's username instead to ensure accountability when creating a Silence.