Skip to content

Automatically set created_by field when creating new Silence#688

Merged
vincent-olivert-riera merged 1 commit intoline:masterfrom
hoangpn:feature/set_created-by_for-silence
Jan 30, 2026
Merged

Automatically set created_by field when creating new Silence#688
vincent-olivert-riera merged 1 commit intoline:masterfrom
hoangpn:feature/set_created-by_for-silence

Conversation

@hoangpn
Copy link
Contributor

@hoangpn hoangpn commented Jan 26, 2026

Currently, when a user creates a new Silence, they can enter anything into the created_by field. If left empty, the user's email will automatically be filled in. In cases where the user doesn't have an email, the value "Promgen" will be set. This can cause ambiguity and make tracking difficult.

Therefore, we have removed the ability to input values for created_by and always set the user's username instead to ensure accountability when creating a Silence.

Copy link
Contributor

@vincent-olivert-riera vincent-olivert-riera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please rebase this branch on master when you have time.

@hoangpn hoangpn force-pushed the feature/set_created-by_for-silence branch from 97f107c to 8a927a0 Compare January 30, 2026 01:01
@hoangpn
Copy link
Contributor Author

hoangpn commented Jan 30, 2026

Looks good to me, but please rebase this branch on master when you have time.

Thank you for your time. I have rebase it on master branch. 🙇

Currently, when a user creates a new Silence, they can enter anything into the created_by
field. If left empty, the user's email will automatically be filled in. In cases where the
user doesn't have an email, the value "Promgen" will be set. This can cause ambiguity and
make tracking difficult.

Therefore, we have removed the ability to input values for created_by and always set the
user's username instead to ensure accountability when creating a Silence.
@hoangpn hoangpn force-pushed the feature/set_created-by_for-silence branch from 8a927a0 to 71d903e Compare January 30, 2026 11:03
@vincent-olivert-riera vincent-olivert-riera merged commit 906a095 into line:master Jan 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants