Show a default value when the path of Exporter is empty#696
Merged
vincent-olivert-riera merged 1 commit intoline:masterfrom Mar 3, 2026
Merged
Conversation
vincent-olivert-riera
previously approved these changes
Mar 2, 2026
Contributor
|
@hoangpn , can you resolve the conflicts and rebase this branch on |
When displaying information about an Exporter on Promgen, if the value of the path attribute is empty, it is shown with the default value "/metrics" in some places, while left empty in others. We have standardized this behavior by always displaying the default value "/metrics" everywhere.
hoangpn
force-pushed
the
chores/show_default_exporter_path
branch
from
8aeb386 to
3edcfd5
Compare
Contributor
Author
|
@vincent-olivert-riera , I have fixed it as your request. 🙇 Please help me to continue reviewing it. |
vincent-olivert-riera
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When displaying information about an Exporter on Promgen, if the value of the path attribute is empty, it is shown with the default value "/metrics" in some places, while left empty in others. We have standardized this behavior by always displaying the default value "/metrics" everywhere.