Skip to content

Conversation

@linearbci
Copy link
Collaborator

Note

Fixes trigger evaluation for actions with built-in triggers

  • Updates to require in addition to a matching entry when contains the action
  • Adjusts tests to assert false when is false (even if events match) and true when both conditions are met

Written by Cursor Bugbot for commit 22a767d7c84deec53cb785e4ad04438dbcd4922f. This will update automatically on new commits. Configure here.

✨ PR Description

Purpose: Fix action triggering logic to correctly evaluate both trigger status and event type for actions with built-in triggers.

Main changes:

  • Modified isActionTriggeredByEvent to require both isTriggered flag and matching event type for built-in trigger actions
  • Updated test expectations to reflect corrected behavior when isTriggered is false
  • Changed logic from evaluating only event type to evaluating both conditions with AND operator

CHANGELOG

🐛 Bug Fixes

  • Fixed action trigger evaluation to properly check conditions before executing actions

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

@linearbci linearbci added the auto-deploy when exists in PR, will auto make release and auto deploy to prod label Jan 26, 2026
@linearbci linearbci requested a review from EladKohavi January 26, 2026 12:18
Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed OSS Licenses high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@EladKohavi EladKohavi merged commit af5d331 into develop Jan 26, 2026
9 of 10 checks passed
@EladKohavi EladKohavi deleted the bump-gitstream-core-to-2.1.248 branch January 26, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-deploy when exists in PR, will auto make release and auto deploy to prod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants