feat: vote with choice yes or no

[linguists]

Introduction

Add vote choice YES or NO.

Summary by CodeRabbit

• New Features

  • Introduced explicit "yes" or "no" voting options for clearer user choices.

• Bug Fixes

  • Enhanced event reporting to include the user's voting choice.

• Refactor

  • Replaced boolean voting with a choice-based system for improved clarity and expressiveness.

• Tests

  • Added tests to verify voting permissions and vote state transitions.
  • Updated existing tests to support the new choice-based voting format.

[coderabbitai]

Warning

Rate limit exceeded

@linguists has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 28 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 434aa3b and ac5789b.

📒 Files selected for processing (2)

• src/lib.rs (12 hunks)
• tests/test_vote.rs (12 hunks)

Walkthrough

The voting mechanism was refactored to use an explicit Choice enum (Yes/No) instead of a boolean flag. The Event enum was updated to remove the VoteWithdrawn variant and enhance the Voted variant with a choice field. Test code and function signatures were updated accordingly to use the new Choice type.

Changes

File(s)	Change Summary
src/events.rs	Added use crate::*;, removed VoteWithdrawn from Event, updated Voted to include choice.
src/lib.rs	Introduced Choice enum, updated all voting logic and signatures to use Choice instead of bool.
tests/test_vote.rs	Replaced "is_vote" boolean arguments with "choice" string values ("yes"/"no") in tests; added tests for vote transitions and pool owner restrictions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Contract
    participant StakingPool

    User->>Contract: vote(choice, staking_pool_id)
    Contract->>StakingPool: get_owner_id(staking_pool_id)
    StakingPool-->>Contract: pool_owner_id
    Contract->>Contract: internal_vote(choice, pool_owner_id)
    Contract-->>User: emit Event::Voted { validator_id, choice }

Loading

Possibly related PRs

• fix: vote from new staking pool contract #5: Extended voting logic by replacing boolean vote parameter with Choice enum and updating event enum accordingly.
• feat: validator voting contract #1: Introduced original Event enum variants that were modified here by removing VoteWithdrawn and updating Voted.

Suggested reviewers

• arkff202310
• dongcool

Poem

A rabbit hops with nimble feet,
Choices now are clear and neat.
No more flags of true or false,
Just "yes" or "no" in the voting waltz.
Events refined, the code anew—
A simpler path for all to view!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.