Skip to content

fix(sdk): skip OverlappingFieldsCanBeMerged validation rule in codegen #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itsmingjie wants to merge 1 commit into from
Closed

fix(sdk): skip OverlappingFieldsCanBeMerged validation rule in codegen #1062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/sdk/codegen.sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ hooks:
config:
documentFile: ./_generated_documents
dedupeFragments: true
# graphql-js v15's OverlappingFieldsCanBeMerged rule incorrectly flags field type conflicts between
# distinct concrete types in a union (e.g. differing nullability on `args` subfields across
# AiConversation*ToolCall types). These can never overlap at runtime. Fixed in graphql-js v16+.
skipDocumentsValidation:
ignoreRules:
- OverlappingFieldsCanBeMerged
skipComments:
- "[Internal]"
- "[INTERNAL]"
Expand Down
3 changes: 3 additions & 0 deletions packages/sdk/codegen.test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ hooks:
- prettier --write
config:
dedupeFragments: true
skipDocumentsValidation:
ignoreRules:
- OverlappingFieldsCanBeMerged
skipComments:
- "[Internal]"
- "[INTERNAL]"
Expand Down