fix: resolve timeout lifecycle and remove forced CLI exit#158
Conversation
5ab1ef4 to
4dd932e
Compare
|
@eveld if you want give this a shot: could you check whether this also fixes your initial issue? |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ab1ef4590
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Confirmed — this fixes the 30s hang from #156. Tested locally by building the branch and timing
The |
Pass AbortController signal to Linear SDK client per attempt so timeouts cancel in-flight fetches. Add regression test for timeout abort behavior and timer cleanup.
What does this PR do?
Fixes timeout lifecycle in GraphQL requests and removes forced process exit so CLI exits naturally after work completes.
Closes #157
Type of change
Checklist
npm run check:cipasses (lint + format)npx tsc --noEmitpasses (type check)npm testpasses (unit tests)Testing
npx vitest run tests/unit/client/graphql-client.test.tsnpm run check:cinpx tsc --noEmitnpm testnpm run buildnode dist/main.js usage > /tmp/linearis-usage.txtNotes for reviewers
program.hook(\"postAction\", () => process.exit(0));workaround.GraphQLClient.request()now creates timeout handle per retry attempt and always clears it infinally.