fix(release): gate version bumps to deliverable-impact commits#172
fix(release): gate version bumps to deliverable-impact commits#172
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3744496dd8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a54ad225f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [ "$bang" = "!" ] || grep -q "BREAKING CHANGE:" <<<"$body"; then | ||
| echo "releasable" | ||
| return |
There was a problem hiding this comment.
Apply scope exclusions before breaking-change classification
classify_commit returns releasable immediately when it sees ! or BREAKING CHANGE, so a commit like fix(ci)!: ... is categorized as releasable and listed under “Ships in stable.” In .releaserc.cjs, scope: ci|release|workflow is explicitly release: false, so those commits should be no-version-impact even when breaking. This makes the promotion PR metadata diverge from semantic-release behavior and can mislead release decisions.
Useful? React with 👍 / 👎.
What does this PR do?
Tightens release automation so package versions advance only for deliverable-impact commits, and promotion PR automation runs only when an actual prerelease is published.
Type of change
Checklist
npm run check:cipasses (lint + format)npx tsc --noEmitpasses (type check)npm testpasses (unit tests)Testing
npm run check:ci npx tsc --noEmit npm testNotes for reviewers
.releaserc.cjs: adds explicitreleaseRulesto prevent bumps for non-deliverable commit types (refactor,chore,ci,docs,style,test,build) and to suppress infra scopes (ci,release,workflow) even if commit type is releasable..github/workflows/release-promote-next-to-main.yml: removespushtrigger so promotion PR upsert runs onrelease.published(or manual dispatch), reducing PR churn from non-releasable commits.