Skip to content

fix(release): gate version bumps to deliverable-impact commits#172

Merged
iamfj merged 3 commits intonextfrom
fix/release-impact-only-bumps
Apr 23, 2026
Merged

fix(release): gate version bumps to deliverable-impact commits#172
iamfj merged 3 commits intonextfrom
fix/release-impact-only-bumps

Conversation

@iamfj
Copy link
Copy Markdown
Member

@iamfj iamfj commented Apr 23, 2026

What does this PR do?

Tightens release automation so package versions advance only for deliverable-impact commits, and promotion PR automation runs only when an actual prerelease is published.

Type of change

  • Bug fix
  • New feature
  • Refactor (no behavior change)
  • Documentation
  • Tests
  • Build / CI

Checklist

  • npm run check:ci passes (lint + format)
  • npx tsc --noEmit passes (type check)
  • npm test passes (unit tests)
  • New code has tests (happy path + primary error case)
  • Commit messages follow Conventional Commits

Testing

npm run check:ci
npx tsc --noEmit
npm test

Notes for reviewers

  • .releaserc.cjs: adds explicit releaseRules to prevent bumps for non-deliverable commit types (refactor, chore, ci, docs, style, test, build) and to suppress infra scopes (ci, release, workflow) even if commit type is releasable.
  • .github/workflows/release-promote-next-to-main.yml: removes push trigger so promotion PR upsert runs on release.published (or manual dispatch), reducing PR churn from non-releasable commits.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3744496dd8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .releaserc.cjs Outdated
@iamfj
Copy link
Copy Markdown
Member Author

iamfj commented Apr 23, 2026

@codex review

@iamfj iamfj merged commit ed629cc into next Apr 23, 2026
8 checks passed
@iamfj iamfj deleted the fix/release-impact-only-bumps branch April 23, 2026 13:44
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a54ad225f3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +87 to +89
if [ "$bang" = "!" ] || grep -q "BREAKING CHANGE:" <<<"$body"; then
echo "releasable"
return
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Badge Apply scope exclusions before breaking-change classification

classify_commit returns releasable immediately when it sees ! or BREAKING CHANGE, so a commit like fix(ci)!: ... is categorized as releasable and listed under “Ships in stable.” In .releaserc.cjs, scope: ci|release|workflow is explicitly release: false, so those commits should be no-version-impact even when breaking. This makes the promotion PR metadata diverge from semantic-release behavior and can mislead release decisions.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant