feat: implement domain-centric discussion interface#183
Conversation
iamfj
force-pushed
the
issue-146-discussion-design
branch
from
bade2a5 to
d1d8ba4
Compare
iamfj
force-pushed
the
issue-146-discussion-design
branch
from
d1d8ba4 to
3977b58
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bade2a57a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4bc9c91f13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
iamfj
force-pushed
the
issue-146-discussion-design
branch
from
4bc9c91 to
94f18a9
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61ca0607bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4599a0479c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Add GraphQL operations for discussion roots, replies, and resolve state changes. Implement discussion service helpers for listing root threads and replies, creating root discussions and replies, editing and deleting root/reply comments, and resolving or unresolving threads. Add service tests covering happy paths, nested reply retrieval, domain validation, pagination behavior, and primary error cases.
Add issue-scoped discussion commands for starting root threads, listing roots and replies, replying, editing, deleting, resolving, and unresolving discussions. Preserve issue delete behavior by using for discussion deletion and keep reply-specific commands alongside generic root-or-reply edit and delete flows. Add command tests for wiring, validation, pagination, and output behavior.
Add project-scoped discussion commands for starting root threads, listing roots and replies, replying, editing, deleting, resolving, and unresolving project discussions. Keep entity deletion separate by using discussion-specific delete commands and preserve reply-specific edit/delete operations beside generic root-or-reply flows. Add command tests for wiring, validation, pagination, and output behavior.
Add initiative-scoped discussion commands for starting root threads, listing roots and replies, replying, editing, deleting, resolving, and unresolving initiative discussions. Align initiative discussion UX and validation with the issue and project command surfaces, including domain- scoped discussion safety checks. Add command tests for wiring, validation, pagination, and output behavior.
Keep legacy command group available as a deprecated compatibility facade over the discussion service. Make deprecation and migration guidance explicit in help text and metadata, while preserving narrowed root-thread reply compatibility and root-or-reply edit/delete support. Add command tests for compatibility delegation, help text, validation, and root-versus-reply behavior.
Document domain-centric discussion workflows in the README, including root-thread listing, nested reply listing, and reply examples. Add migration guidance from deprecated commands to the newer issue discussion commands and note compatibility limits where they still apply.
iamfj
force-pushed
the
issue-146-discussion-design
branch
from
3cf434f to
7631b38
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7631b38090
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
What does this PR do?
Implements issue #146 discussion interface redesign by introducing domain-centric discussion commands across
issues,projects, andinitiatives, while keepingcommentsas a deprecated compatibility façade.Key changes:
discussion-servicefor:issues,projects, andinitiatives:discuss,discussions,replies,reply,edit,delete-comment,edit-reply,delete-reply,resolve,unresolvedelete-commentcommentscommands through discussion service with explicit deprecation + migration guidanceCloses #146
Type of change
Checklist
npm run check:cipasses (lint + format)npx tsc --noEmitpasses (type check)npm testpasses (unit tests)Testing
Executed in worktree branch:
npm run check:ci npx tsc --noEmit npm test npm run buildResults:
npm test: 53 files / 654 tests passingTargeted verification additionally run during implementation:
npx vitest run tests/unit/services/discussion-service.test.tsnpx vitest run tests/unit/commands/issues.test.ts tests/unit/commands/projects.test.ts tests/unit/commands/initiatives.test.tsnpx vitest run tests/unit/commands/comments.test.tsNotes for reviewers
Docs note:
delete-commentcommands.Risk note:
commentsbehavior. Entity delete commands remain unchanged, and discussion deletion usesdelete-commentto avoid command collisions.Additional notes:
commentsremains available for backward compatibility but is explicitly deprecated in help/meta text.comments replyexpects a root discussion thread ID; nested reply targets are not supported in compatibility mode.edit <comment>accepts root discussion IDs and reply IDs.delete-comment <comment>was added instead of overloading existing entitydeletecommands, preserving backward compatibility forissues delete,projects delete, andinitiatives delete.