Run x86 apple job on x86 hardware#219
Open
Shnatsel wants to merge 1 commit into
Open
Conversation
LaurenzV
approved these changes
May 19, 2026
Collaborator
LaurenzV
left a comment
LaurenzV
left a comment
There was a problem hiding this comment.
I guess the question is how long those will be supported by GitHub, but for now LGTM!
Contributor
Author
|
They're maintained until fall 2027, but Apple is removing Rosetta in 2028 anyway. |
Contributor
Author
|
Hmm, this looks like a flaw in github merge queue implementation: main has a CI check that this branch doesn't, so auto-merge is never going to happen because one of the checks will never execute. Someone with greater access than me will need to bypass merge queue somehow, e.g. disable it, merge this PR and then re-enable it. Or perhaps the required checks are listed explicitly somewhere? |
Collaborator
|
I don’t have these permissions I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macos-latestis ARM, and runs x86 binaries through rosetta. We need to specify the Intel runner explicitly to get x86 hardware.Motivation: #218 (comment)
Our test suite is now so thorough that it caught a Rosetta bug 😎