Replace remaining NEON unsafe loads with checked_transmute_copy#237
Merged
Conversation
LaurenzV
approved these changes
May 27, 2026
Collaborator
LaurenzV
left a comment
LaurenzV
left a comment
There was a problem hiding this comment.
Maybe we should move them out of the unsafe block then?
Collaborator
|
Also, it doesn't seem like any WASM ones changed. |
Contributor
Author
|
Ah, sorry, I was confused by the way github presented the diff. I thought the added impl was for wasm, but it wasn't. I didn't move them out of the unsafe block to reduce conflicts with #236 but I can do that if you prefer. |
Collaborator
|
Ah ok, no it's fine to leave them there! Just rename the PR maybe |
Shnatsel
changed the title
Shnatsel
added a commit
to Shnatsel/fearless_simd
that referenced
this pull request
May 27, 2026
Merged origin/main commit 650815d. The merge applied cleanly.
Shnatsel
added a commit
to Shnatsel/fearless_simd
that referenced
this pull request
May 27, 2026
PR linebender#237 only updates NEON load construction. The AVX512 branch-specific unsafe load sites were already adapted in the PR linebender#233 follow-up, and a search found no remaining load intrinsics needing the linebender#237 pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #233 which did this for x86
Leaves
vld4q_*untouched because those are deinterleaving loads that genuinely need an intrinsic.