Conversation
laurenz-canva
force-pushed
the
laurenz/remove_parley_draw
branch
from
ca1dcf3 to
6c3029e
Compare
laurenz-canva
force-pushed
the
laurenz/remove_parley_draw
branch
from
b8f5cdc to
33254bd
Compare
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Looks good but of course the git rev needs to be updated once the vello PR lands.
Cargo.toml
Outdated
| vello_common = { git = "https://github.com/linebender/vello.git", rev = "de56b48" } | ||
| vello_cpu = { git = "https://github.com/linebender/vello.git", rev = "de56b48" } | ||
| vello_hybrid = { git = "https://github.com/linebender/vello.git", rev = "de56b48" } | ||
|
|
There was a problem hiding this comment.
Given that you updated these to 0.0.7 already, should this patch even remain? Perhaps it can be removed.
There was a problem hiding this comment.
I think we'll need to depend on the git version of vello, otherwise it won't match the version of vello that glifo is depending on. But it could probably be a regular git dep rather than a patch (as we won't be publishing any of the crates with this dependency).
There was a problem hiding this comment.
As you want! Just did it to keep it consistent with how it's currently done.
laurenz-canva
force-pushed
the
laurenz/remove_parley_draw
branch
from
33254bd to
900311f
Compare
|
@grebmeg Same as before, feel free to merge yourself, otherwise I'll do it tomorrow. |
Not hooked up yet into vello, just the raw import. First commit is a 1:1 copy-paste of the crate, all subsequent commits finetune it to work with the workspace structure. This is the actual diff: 96c9482...9b070fd Accompanying parley PR: linebender/parley#586 --------- Co-authored-by: Laurenz Stampfl <47084093+LaurenzV@users.noreply.github.com> Co-authored-by: Kaur Kuut <strom@nevermore.ee>
|
Parley 0.8 got released so this can now be rebased so we can move towards merging it. |
|
Will do! |
# Conflicts: # .github/workflows/ci.yml # Cargo.lock # examples/vello_editor/Cargo.toml
|
Updated to newest vello main rev. |
4 participants
Accompanying vello commit: linebender/vello#1539