Backport #126 (Linebender Resource Handle) to v0.4.x #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
added a commit
to DJMcNab/cosmic-text
that referenced
this pull request
Sep 9, 2025
This is not to be merged, but is instead being used to validate linebender/peniko#129 by running your CI Note that it's likely that Cosmic text will want to replace your Peniko usage with Linebender Resource Handle instead, once Peniko 0.4.1 is out
nicoburns
approved these changes
Sep 9, 2025
Contributor
nicoburns
left a comment
nicoburns
left a comment
There was a problem hiding this comment.
LGTM subject to backwards compat checking
DJMcNab
force-pushed
the
linebender_resource_handle_backport
branch
from
d86ffcd to
715cf10
Compare
Member
Author
|
As discussed in #126, I've tweaked the CHANGELOG, therefore I've requested a new review. I don't plan to merge this before Office Hours tomorrow, to get final consensus confirmed. |
nicoburns
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #126, as discussed in #linebender > raw_resource_handle crate extraction from Peniko @ 💬
This fails Cargo Semver Checks because of obi1kenobi/cargo-semver-checks#638. Therefore, I have manually checked that this works in Xilem and Cosmic Text.
Those tests were performed using:
This is the more permanent equivalent of #107, and will mean that 0.4.x, 0.3.x and 0.5.x are all using the same
Font/Blobtypes.