Skip to content

Support styling via CSS#1047

Open
simartin wants to merge 1 commit into
linebender:mainfrom
simartin:svg_2_styling
Open

Support styling via CSS#1047
simartin wants to merge 1 commit into
linebender:mainfrom
simartin:svg_2_styling

Conversation

@simartin
Copy link
Copy Markdown
Contributor

@simartin simartin commented May 9, 2026

Per https://www.w3.org/TR/SVG/styling.html#StylingUsingCSS, SVG2 should support this capability.

(I noticed this was not the case when inspecting servo's SVG compliance test results)

@simartin simartin marked this pull request as draft May 9, 2026 07:52
@simartin
Copy link
Copy Markdown
Contributor Author

simartin commented May 9, 2026

Marking it as draft because I uncovered an issue with inheritability while running servo's SVG testsuite along with this patch.

Per https://www.w3.org/TR/SVG/styling.html#StylingUsingCSS, SVG2 should
support this capability.

Signed-off-by: Simon Martin <simon@nasilyan.com>
@simartin
Copy link
Copy Markdown
Contributor Author

simartin commented May 9, 2026

With this version we only improve servo's SVG compliance testsuite:

simon@framedora:~/Dev/projects/servo/servo$ ./mach -v test-wpt --dev tests/wpt/tests/svg
Running WPT tests with /home/simon/Dev/projects/servo/servo/target/debug/servoshell
Running 1117 tests in web-platform-tests

  ▶ PASS [expected FAIL] /svg/geometry/reftests/circle-001.svg

  ▶ PASS [expected FAIL] /svg/geometry/reftests/circle-002.svg

  ▶ PASS [expected FAIL] /svg/geometry/reftests/circle-003.svg

  ▶ PASS [expected FAIL] /svg/geometry/reftests/rect-003.svg

  ▶ PASS [expected FAIL] /svg/path/property/d-none.svg

  ▶ PASS [expected FAIL] /svg/geometry/reftests/rect-001.svg

  ▶ PASS [expected FAIL] /svg/geometry/reftests/rect-002.svg

Ran 1117 tests finished in 113.8 seconds.
  • 1110 ran as expected.
  • 7 tests passed unexpectedly

@simartin simartin marked this pull request as ready for review May 9, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant