Support actual angles for HSL/HSLA colors#62
Merged
Conversation
This makes hsl/hsla properly work with hue and alpha values with a deg/grad/rad/turn suffix, that should be supported according to https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Values/color_value/hsl I noticed this gap while reviewing the SVG compliance test suite of servo (that relies on resvg, that uses svgtypes). Signed-off-by: Simon Martin <simon@nasilyan.com>
LaurenzV
changed the title
Collaborator
|
LGTM thanks! |
LaurenzV
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes hsl/hsla properly work with hue and alpha values with a deg/grad/rad/turn suffix, that should be supported according to
https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Values/color_value/hsl
I noticed this gap while reviewing the SVG compliance test suite of servo (that relies on resvg, that uses svgtypes).