Conversation
# Conflicts: # sparse_strips/vello_common/src/encode.rs
grebmeg
approved these changes
Aug 11, 2025
| ctx.fill_rect(&Rect::new(0.0, 0.0, 4.0, 4.0)); | ||
| } | ||
|
|
||
| // See <https://github.com/linebender/vello/issues/1129> |
Collaborator
| // TODO: The `color` crate will always interpolate in premultiplied space, while for Srgb | ||
| // we do it in unpremultiplied space since this is more desirable for most 2D rendering | ||
| // situations (see https://github.com/linebender/vello/issues/1129), so the results might | ||
| // look off until this is implemented in the `color` crate. |
Collaborator
There was a problem hiding this comment.
Is this the issue in color crate related to what you mentioned? Can we link it here, even though it will hopefully be closed soon?
|
|
||
| // See <https://github.com/linebender/vello/issues/1129> | ||
| #[vello_test] | ||
| fn gradient_with_last_stop_0_opacity(ctx: &mut impl Renderer) { |
Collaborator
There was a problem hiding this comment.
I think if you pull from main, you’ll see another test called gradient_color_alpha added in #1142
Collaborator
Author
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 4, 2025
…ha space (#1145) Some SIMD stuff is from #1140 Depends on linebender/peniko#115 This currently includes only Vello CPU/Hybrid implementation, but I plan to do classic Vello too. Fixes #1056 Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't solve the issue for gradients with non-SRGB color space because the
colorcrate will always provide a linear approximation in premultiplied space, but at least we can resolve the issue for SRGB color spaces, which seems like a good first step.Fixes #1129.