-
Notifications
You must be signed in to change notification settings - Fork 211
Update the changelog for sparse strips renderers #1344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed the content, just given a first pass and found this issue.
As a small process note, I see that you've not updated the versions in the Cargo.toml files. That is correct, because this is the CHANGELOG update PR, but note that we also shouldn't be updating the version numbers in the CHANGELOG files either, until the actual release PR. That ensures that the changelog file on main accurately reflects the actual released/unreleased state of the commit. We should also probably change the title of this PR.
I'd also like to see a PR to make sure our dependencies are up-to-date before the release.
Remember that we have https://linebender.org/wiki/process/release/ documented. If anything in there is unclear, feel free to reach out to ask!
|
I reverted the version bump in the changelog, as mentioned in the Zulip, I'm not sure what to do about the dependencies though. Should I just blindly update all of them, even if some aren't used by sparse strips? |
DJMcNab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I've not done the check to see if there's anything else which should have been included.
I've set the release date for tomorrow.