Upgrade to wgpu v29. Reduce MSRV to 1.88. by nicoburns · Pull Request #1534 · linebender/vello

nicoburns · 2026-03-24T19:16:23Z

Upgrade Vello and Vello Hybrid to wgpu v29. Also reduces MSRV to 1.88 as wgpu lowered theirs.

https://github.com/gfx-rs/wgpu/releases/tag/v29.0.0

nicoburns · 2026-03-24T20:22:35Z

 ## Minimum supported Rust Version (MSRV)

-This version of Vello has been verified to compile with **Rust 1.86** and later.
+This version of Vello has been verified to compile with **Rust 1.88** and later.


This should have been updated to 1.92 with the wgpu v28 bump but got missed

LaurenzV · 2026-03-25T07:18:56Z

+            CurrentSurfaceTexture::Occluded
+            | CurrentSurfaceTexture::Timeout
+            | CurrentSurfaceTexture::Outdated
+            | CurrentSurfaceTexture::Suboptimal(_) => {
+                return;
+            }


Should we really silently return in case those happened? Seems to me like, especially for the example, it's fine to just panic here

People will copy the example.

But then is the best thing to do really to just return? I don't know, I'm not super familiar with wgpu API. 😄

It's important not to panic here (which we were previously doing!). These errors can and do happen relatively often (we've gotten bug reports for Blitz), but they are transient/recoverable errors so the recommended thing to do is skip the current frame and immediately retry by rendering another frame.

See the WGPU v29 release notes, where they've intentionally changed this API not to use Result to push people towards not just calling unwrap/expect on these errors. https://github.com/gfx-rs/wgpu/releases/tag/v29.0.0

For some of those cases, I'm supposed to "reconfigure the surface", which I have done in the native cases, but I wasn't sure how to do that on the webgl backend. And for the Lost case you're apparently supposed to recreate the device in some cases (but I think this happens much less often so I'm happy to just continue panicking here for now).

LaurenzV · 2026-03-25T07:19:26Z

-                    .surface
-                    .get_current_texture()
-                    .expect("failed to get surface texture");
+                let surface_texture = match surface.surface.get_current_texture() {


LaurenzV · 2026-03-25T07:21:33Z

        let backend_options = wgpu::BackendOptions::from_env_or_default();
-        let instance = Instance::new(&wgpu::InstanceDescriptor {
+        let instance = Instance::new(wgpu::InstanceDescriptor {
+            // TODO: consider allowing users to pass display handle when constructing a RenderContext


Will this cause regressions for existing users if we don't allow this now?

My understanding is that this primarily impacts GL backends. Which I think is not relevant at all for Vello Classic. It could potentially affect Vello Hybrid (but the WebGL backend has a separate setup where we do already pass the "web display handle").

So I believe it would be "people running Vello Hybrid with OpenGL on native platforms" that would need this.

PR for this is gfx-rs/wgpu#8782

LaurenzV · 2026-03-25T07:21:43Z

-                    .surface
-                    .get_current_texture()
-                    .expect("failed to get surface texture");
+                let surface_texture = match surface.surface.get_current_texture() {


Same as before.

nicoburns · 2026-04-21T12:31:02Z

Very confused what's going on with CI here: the errors seem to reference code which doesn't exist (either locally or in the Github view of the file). And the commands are passing locally :/ And I've also tried busting the cache (by changing the cache key), which seems to be working because it says "no cache found", but that doesn't seem to help.

@xStrom @DJMcNab Any idea what might be going on here? Am I being an idiot?

DJMcNab · 2026-04-21T12:34:04Z

On mobile, so hard to check. Best guess is that it merges clean, so CI is running on the combined merge.

That behaviour sort of makes sense, but GitHub explains it exceedingly poorly; you have to infer what's going on.

So to rule that out, I'd try a rebase (or a fast forward merge? Idk, I always rebase)

LaurenzV · 2026-04-21T12:36:47Z

I think you probably just haven't rebased onto newest main, which contains the new opaque/alpha strips path.

DJMcNab

All seems reasonable to me, although this is a mobile only review, and I've not yet read the upstream changelog, so won't review it.

If I've not reviewed by 16:30ish Sydney time tomorrow, feel free to ping again here and/or on Zulip.

DJMcNab · 2026-04-21T12:39:48Z

-                    .expect("failed to get surface texture");
+                let surface_texture = match surface.surface.get_current_texture() {
+                    CurrentSurfaceTexture::Success(surface_texture) => surface_texture,
+                    CurrentSurfaceTexture::Outdated | CurrentSurfaceTexture::Suboptimal(_) => {


There are reasonable arguments for still drawing to a suboptimal surface. I'm worried about the case where suboptimal means "use a different device", which would mean we would loop here (this is unvalidated, to be clear, as I'm on mobile)

Given that this is an example, I don't really care about it.

Yeah, not sure. Either way, this seems better than panicking (which is what we were doing before). Handling the "should use a different device case" seems like it would be good to do in future (also for CurrentSurfaceTexture::Lost), but is probably quite rare in practice?

DJMcNab · 2026-04-21T12:42:59Z

+        let instance = wgpu::Instance::new(wgpu::InstanceDescriptor {
            backends: wgpu::Backends::GL,
-            ..Default::default()
+            ..wgpu::InstanceDescriptor::new_with_display_handle(Box::new(OurDisplayHandle))


Why not Box::new(DisplayHandle::web())? I don't think this example is quite so precious about memory usage. We could give a hint comment if we really wanted to.

Because that wasn't valid until wgpu v29.0.1! But we should be able to change that now :)

Hmm... actually this still isn't working, even with v29.0.1. I've reinstated this code. Issue is that DisplayHandle::web() isn't Send/Sync. I did have discussions with wgpu maintainers about removing this bound for WASM (which wgpu already does elsewhere), but I don't think this has actually happened yet.

Ah, apologies. Thanks for checking! If there's an upstream issue, we should link to it in a comment (not checked if you're already done this).

DJMcNab · 2026-04-21T12:52:08Z

    }

-    fn configure_surface(&self, surface: &RenderSurface<'_>) {
+    pub fn configure_surface(&self, surface: &RenderSurface<'_>) {


Is this finally my impetus for killing this file entirely?

Either way, that shouldn't happen in this PR...

I do now maintain https://docs.rs/wgpu_context as part of AnyRender which can potentially serve as a replacement (it would be annoying if vello depended on this, but a dev-dependency would be fine).

Signed-off-by: Nico Burns <nico@nicoburns.com>

nicoburns · 2026-04-21T14:13:10Z

On mobile, so hard to check. Best guess is that it merges clean, so CI is running on the combined merge.
That behaviour sort of makes sense, but GitHub explains it exceedingly poorly; you have to infer what's going on.
So to rule that out, I'd try a rebase (or a fast forward merge? Idk, I always rebase)

(this was it. I had rebased on my local main, but I didn't have the latest locally - thanks for the help!)

nicoburns · 2026-04-23T14:09:14Z

If I've not reviewed by 16:30ish Sydney time tomorrow, feel free to ping again here and/or on Zulip.

@DJMcNab ping!

DJMcNab

I've not re-reviewed this - I'll aim to post-review next week. I've got an extra long weekend, so that won't be before Tuesday. But happy to land to let dependant PRs happen.

nicoburns · 2026-04-23T22:43:04Z

I've not re-reviewed this - I'll aim to post-review next week. I've got an extra long weekend, so that won't be before Tuesday. But happy to land to let dependant PRs happen.

Cool. In that case I will merge now to avoid conflicts.

nicoburns requested review from laurenz-canva and waywardmonkeys March 24, 2026 19:16

nicoburns force-pushed the wgpu29 branch from 703876b to b8a6d37 Compare March 24, 2026 19:31

nicoburns changed the title ~~Upgrade to wgpu v29~~ Upgrade to wgpu v29. Reduce MSRV to 1.88. Mar 24, 2026

nicoburns force-pushed the wgpu29 branch from b8a6d37 to 1174423 Compare March 24, 2026 20:13

nicoburns commented Mar 24, 2026

View reviewed changes

LaurenzV reviewed Mar 25, 2026

View reviewed changes

nicoburns requested review from DJMcNab and xStrom March 25, 2026 12:23

nicoburns mentioned this pull request Mar 25, 2026

chore: upgrade vello dependencies to 0.0.7 and wgpu to 28 linebender/parley#583

Closed

nicoburns force-pushed the wgpu29 branch from 1174423 to a24ed55 Compare April 21, 2026 11:57

nicoburns requested a review from LaurenzV April 21, 2026 11:58

nicoburns force-pushed the wgpu29 branch from a04b425 to ab4229e Compare April 21, 2026 12:50

DJMcNab reviewed Apr 21, 2026

View reviewed changes

nicoburns force-pushed the wgpu29 branch from ab4229e to 285b2f5 Compare April 21, 2026 13:15

Upgrade to wgpu v29

20b4c83

Signed-off-by: Nico Burns <nico@nicoburns.com>

nicoburns force-pushed the wgpu29 branch 2 times, most recently from b9d22ce to 2854169 Compare April 21, 2026 13:38

Review feedback

91d2ba8

Signed-off-by: Nico Burns <nico@nicoburns.com>

nicoburns force-pushed the wgpu29 branch from 2854169 to 91d2ba8 Compare April 21, 2026 13:47

taj-p reviewed Apr 22, 2026

View reviewed changes

Comment thread sparse_strips/vello_common/CHANGELOG.md Outdated

Fix typo: 1.98 -> 1.88

f1d1799

DJMcNab approved these changes Apr 23, 2026

View reviewed changes

nicoburns added this pull request to the merge queue Apr 23, 2026

Merged via the queue into linebender:main with commit 9261917 Apr 23, 2026
17 checks passed

nicoburns deleted the wgpu29 branch April 23, 2026 22:58

Conversation

nicoburns commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicoburns Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicoburns Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicoburns commented Apr 21, 2026

Uh oh!

DJMcNab commented Apr 21, 2026

Uh oh!

LaurenzV commented Apr 21, 2026

Uh oh!

DJMcNab left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicoburns Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicoburns Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicoburns Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicoburns commented Apr 21, 2026

Uh oh!

Uh oh!

nicoburns commented Apr 23, 2026

Uh oh!

DJMcNab left a comment

Choose a reason for hiding this comment

Uh oh!

nicoburns commented Apr 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

nicoburns commented Mar 24, 2026 •

edited

Loading

nicoburns Mar 25, 2026 •

edited

Loading

nicoburns Mar 25, 2026 •

edited

Loading

nicoburns Apr 21, 2026 •

edited

Loading

nicoburns Apr 21, 2026 •

edited

Loading

nicoburns Apr 21, 2026 •

edited

Loading