Fix clipping in recording replay#1569
Merged
Merged
Conversation
LaurenzV
reviewed
Apr 14, 2026
LaurenzV
approved these changes
Apr 14, 2026
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate_strips_from_commands(used byprepare_recording) was passingNonefor the clip path to the strip generator, while the live draw paths (fill_path,stroke_path) pass the active scissor clip.This caused recorded geometry inside a
push_clip_pathscope to render unclipped on replay.This PR fixes that by adding
current_clip_path()to theDispatchertrait and querying it per-command in the strip generation loop. Arecording_inside_clipregression test covers bothFillRectandFillPathcommands inside a clip scope, verifying geometry is clipped to the scissor rect.The bug was introduced in #1203.
I think a deeper issue is that clip paths are not part of the recording, but I'm not sure they should be, so I'm keeping this PR minimal