Use state guard in WebGL constructor#1603
Merged
Merged
Conversation
taj-p
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another bug that makes it evident that we should work on a better abstraction for our WebGL backend soon to avoid subtle state bugs! Note that this is only a bandaid fix until we have a better abstraction in place.
Currently, when constructing a new
WebGlRenderer, we end up leaving a different framebuffer bound tot he WebGL2 context. As a result. when trying to create a second renderer, we hit a panic becauseDEPTH_BITSends up being 0. For now, the solution is to simply use a state guard in the constructor so that the default framebuffer is bound again in the end.It's possible that we currently have other functions that result in leaked framebuffers, I haven't checked that yet. As mentioned, this is just a bandaid fix for this specific bug.