vello: Support brush transforms for glyph runs#1632
Merged
waywardmonkeys merged 1 commit intoMay 15, 2026
Merged
Conversation
waywardmonkeys
force-pushed
the
vello-classic-glyph-run-brush-transform
branch
from
4d0f429 to
bc5e006
Compare
raphlinus
approved these changes
May 14, 2026
Contributor
raphlinus
left a comment
raphlinus
left a comment
There was a problem hiding this comment.
Looks good, I didn't find any problems. Thanks!
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Add a `brush_transform` field to encoded `GlyphRun` and expose it through `DrawGlyphs`. The resolver now emits an additional transform immediately before the glyph-run `PATH` marker, so gradient and image brushes use the run paint transform while per-glyph geometry transforms remain unchanged. Thread the option through the scenes text helper and add smoke snapshot coverage using a transformed linear gradient across rendered text. BREAKING CHANGE: Low-level callers constructing `vello_encoding::GlyphRun` literals must initialize `brush_transform`, usually to `None`. Fixes linebender#1631.
waywardmonkeys
force-pushed
the
vello-classic-glyph-run-brush-transform
branch
from
bc5e006 to
3096ead
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
brush_transformfield to encodedGlyphRunand expose it throughDrawGlyphs. The resolver now emits an additional transform immediately before the glyph-runPATHmarker, so gradient and image brushes use the run paint transform while per-glyph geometry transforms remain unchanged.Thread the option through the scenes text helper and add smoke snapshot coverage using a transformed linear gradient across rendered text.
BREAKING CHANGE: Low-level callers constructing
vello_encoding::GlyphRunliterals must initializebrush_transform, usually toNone.Fixes #1631.