Make pgpu-render compile on non apple platforms#180
Merged
raphlinus merged 2 commits intolinebender:mainfrom Jul 13, 2022
Merged
Make pgpu-render compile on non apple platforms#180raphlinus merged 2 commits intolinebender:mainfrom
pgpu-render compile on non apple platforms#180raphlinus merged 2 commits intolinebender:mainfrom
Conversation
Also add `resolver="2"` to the entire workspace, in case we gain a wgpu dependency
Collaborator
|
This looks good to me as well. It seems we might be able to slip this in without creating any merge conflicts. |
raphlinus
approved these changes
Jul 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes use of a cfg to disable the metal dependencies and the functions they are used in on ios or macos.
This is also reflected in the generated
cbindgencode, using thewith_definefeature.Also add
resolver="2"to the workspace root, primarily in case we gain awgpudependency.I've also added a fix for the android example