feat(cli): add --sound flag for task completion#1157
feat(cli): add --sound flag for task completion#1157vrcprl merged 8 commits intolingodotdev:mainfrom
Conversation
| "Play sound on completion, partially completion and failed of the task" | ||
| ) | ||
| .action(async (args) => { | ||
| // log the args in terminal |
There was a problem hiding this comment.
Is there a specific reason you added this, or was it just for debugging during development? If you're done with development and it wasn't there before, maybe remove it :)
There was a problem hiding this comment.
This is probably waaay too picky of me:
Compared to the success sound effect, this sound effect is really quiet. I think it would be nicer if I could hear it a little better.
|
In my review, I mentioned a big issue. Here are the details: The sound assets won't be published to npm, since lingo.dev/packages/cli/package.json Lines 99 to 102 in 764d1f0 
To fix this, add |
…ngo.dev into feat/cli-play-music
|
@The-Best-Codes |
vrcprl
left a comment
vrcprl
left a comment
There was a problem hiding this comment.
Looks great! I really enjoyed testing it.
|
@vrcprl @The-Best-Codes |
* feat(cli): add --sound flag for task completion * fix: address review comments * style: format code with prettier * chore: formatting * chore: changeset --------- Co-authored-by: Veronica Pril <veranika.prilutskaya@gmail.com>
3 participants
After all main task will completed it make the
successsoundMain Task
If any of the task failed or the
runcommand will fail it'll generate thefailuresound.#1079