fix(cli): fix API key check condition that breaks Ollama provider #1748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrcprl
changed the title
vrcprl
approved these changes
Jan 20, 2026
17prateek12
pushed a commit
to 17prateek12/lingo.dev
that referenced
this pull request
Jan 23, 2026
…ngodotdev#1748) * fix(cli): change error check to only fail when params.apiKeyName is missing and skipAuth is not true * fix(cli): add changeset for fixed API key check condition --------- Co-authored-by: Veronica Prilutskaya <veronica@lingo.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix API key check condition that breaks the Ollama provider.
Changes
skipAuthis false. Previously, a missing API key name was checked independently fromskipAuth, causing to throw a false-positive error when the Ollama provider that doesn't use auth doesn't provide an API key name (which is correct behaviour).Testing
Business logic tests added:
Visuals
Required for UI/UX changes:
Checklist
Closes #1747