-
Notifications
You must be signed in to change notification settings - Fork 834
feat: add gpg support #1957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gpg support #1957
Conversation
📝 WalkthroughWalkthroughRemoved the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@action.yml`:
- Line 23: The workflow's CLI invocation omits the declared input
inputs.gpg-sign so user values are ignored; update the command that currently
includes "--parallel ${{ inputs.parallel }}" to also pass the signing flag
(e.g., add "--gpg-sign ${{ inputs.gpg-sign }}" next to the parallel flag) or, if
you prefer the unused input removed, delete the inputs.gpg-sign definition
instead—locate the CLI invocation containing "--parallel ${{ inputs.parallel }}"
and the input block that defines gpg-sign and make one of these two edits so the
input is either consumed or removed.
just revert waste ci param
Summary by CodeRabbit
Changes
Chores