Skip to content

Conversation

@cherkanovart
Copy link
Contributor

@cherkanovart cherkanovart commented Feb 3, 2026

just revert waste ci param

Summary by CodeRabbit

  • Changes

    • Removed the gpg-sign flag from the composite action workflow step.
  • Chores

    • Added a changeset configuration file.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

Removed the gpg-sign input and its forwarded --gpg-sign argument from the GitHub Actions composite action (action.yml) and added a new changeset file documenting the change.

Changes

Cohort / File(s) Summary
Changeset Entry
.changeset/ten-doodles-sing.md
Added a new changeset file containing two lines (---).
GitHub Actions Configuration
action.yml
Removed the gpg-sign input and the corresponding --gpg-sign argument from the Run step; existing --parallel usage remains unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 I nibbled flags beneath the moon,

Poked a hole in gpg-sign's tune,
Parallel hops across the lawn,
A tiny change, the dawn is drawn. 🥕

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title claims to 'add gpg support' but the actual changes remove GPG signing functionality from action.yml, making the title misleading and contradictory to the changeset. Update the title to reflect the actual change, such as 'chore: remove GPG signing input from action.yml' or 'fix: revert GPG signing parameter'.
Description check ⚠️ Warning The PR description is vague and incomplete, providing only 'just revert waste ci param' without following the required template structure or explaining what was reverted or why. Provide a detailed description following the template: add a Summary section explaining the revert, list the specific changes, and document whether testing was performed.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/add-gpg-support

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@action.yml`:
- Line 23: The workflow's CLI invocation omits the declared input
inputs.gpg-sign so user values are ignored; update the command that currently
includes "--parallel ${{ inputs.parallel }}" to also pass the signing flag
(e.g., add "--gpg-sign ${{ inputs.gpg-sign }}" next to the parallel flag) or, if
you prefer the unused input removed, delete the inputs.gpg-sign definition
instead—locate the CLI invocation containing "--parallel ${{ inputs.parallel }}"
and the input block that defines gpg-sign and make one of these two edits so the
input is either consumed or removed.

@cherkanovart cherkanovart changed the title Feat/add gpg support feat: add gpg support Feb 3, 2026
@cherkanovart cherkanovart merged commit d194bb0 into main Feb 3, 2026
12 of 13 checks passed
@cherkanovart cherkanovart deleted the feat/add-gpg-support branch February 3, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants