Skip to content

fix: update PHP SDK code style to fix failing workflow#689

Merged
maxprilutskiy merged 1 commit intomainfrom
devin/1746162381-fix-php-sdk-style
May 2, 2025
Merged

fix: update PHP SDK code style to fix failing workflow#689
maxprilutskiy merged 1 commit intomainfrom
devin/1746162381-fix-php-sdk-style

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Fix PHP SDK Code Style Issues

This PR fixes the code style issues in the PHP SDK that were causing the workflow to fail. The changes include:

  1. Renamed the httpClient property to _httpClient in LingoDotDevEngine.php
  2. Renamed private methods to have an underscore prefix (_localizeChunk, _extractPayloadChunks, _countWordsInRecord, _createId)
  3. Updated references to these methods throughout the file
  4. Fixed doc comments by separating @return tags from parameter tags
  5. Updated the LingoDotDevEngineTest.php file to reference the renamed _httpClient property

Link to Devin run

https://app.devin.ai/sessions/0c1c7a8ae9604c4fa3877933f51b7c61

Requested by

Max Prilutskiy (max@lingo.dev)

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration Bot changed the title Fix PHP SDK Code Style Issues fix: update PHP SDK code style to fix failing workflow May 2, 2025
@maxprilutskiy maxprilutskiy merged commit 7496972 into main May 2, 2025
3 of 4 checks passed
@maxprilutskiy maxprilutskiy deleted the devin/1746162381-fix-php-sdk-style branch May 2, 2025 05:23
mainstar123 pushed a commit to mainstar123/lingo.dev that referenced this pull request Jul 7, 2025
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Max Prilutskiy <maks.prilutskiy@gmail.com>
17prateek12 pushed a commit to 17prateek12/lingo.dev that referenced this pull request Jan 23, 2026
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Max Prilutskiy <maks.prilutskiy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant