fix: ensure sdk version is set before root composer install#727
Merged
maxprilutskiy merged 1 commit intomainfrom May 3, 2025
Merged
Conversation
Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PHP SDK Publishing Workflow
Problem
The PHP SDK publishing workflow is failing at the "Install root composer dependencies" step because the version field in the PHP SDK's composer.json is empty when Composer tries to resolve dependencies from the root composer.json.
Solution
This fix ensures that the PHP SDK version is always properly set before the root composer.json tries to resolve dependencies, preventing the "Invalid version string" error.
Link to Devin run: https://app.devin.ai/sessions/6407d462e80c47b4b98a7af1e3565247
User: Max Prilutskiy (max@lingo.dev)