Skip to content

fix: ensure sdk version is set before root composer install#727

Merged
maxprilutskiy merged 1 commit intomainfrom
devin/1746237677-fix-php-sdk-publishing-workflow
May 3, 2025
Merged

fix: ensure sdk version is set before root composer install#727
maxprilutskiy merged 1 commit intomainfrom
devin/1746237677-fix-php-sdk-publishing-workflow

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Fix PHP SDK Publishing Workflow

Problem

The PHP SDK publishing workflow is failing at the "Install root composer dependencies" step because the version field in the PHP SDK's composer.json is empty when Composer tries to resolve dependencies from the root composer.json.

Solution

  1. Added a dedicated step to ensure the SDK version is set before installing root dependencies
  2. Added more debug logging to help diagnose any future issues
  3. Added validation to ensure the version is properly set before proceeding with installation

This fix ensures that the PHP SDK version is always properly set before the root composer.json tries to resolve dependencies, preventing the "Invalid version string" error.

Link to Devin run: https://app.devin.ai/sessions/6407d462e80c47b4b98a7af1e3565247
User: Max Prilutskiy (max@lingo.dev)

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@maxprilutskiy maxprilutskiy merged commit 76b2e5e into main May 3, 2025
2 checks passed
@maxprilutskiy maxprilutskiy deleted the devin/1746237677-fix-php-sdk-publishing-workflow branch May 3, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant