Skip to content

fix: use --no-check-publish flag for composer validation#730

Merged
maxprilutskiy merged 1 commit intomainfrom
devin/1746241145-fix-php-sdk-validation
May 3, 2025
Merged

fix: use --no-check-publish flag for composer validation#730
maxprilutskiy merged 1 commit intomainfrom
devin/1746241145-fix-php-sdk-validation

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Fix PHP SDK Publishing Workflow Validation

Problem

The PHP SDK publishing workflow is failing at the "Validate composer.json" step because the strict validation doesn't allow the version field in packages published on Packagist.

Solution

Modified the composer validation step to use the --no-check-publish flag instead of --strict, which allows the version field to be present while still validating the overall structure of the composer.json file.

This fix ensures that the PHP SDK publishing workflow can continue to run successfully while maintaining the version field needed for automatic version bumping.

Link to Devin run: https://app.devin.ai/sessions/6407d462e80c47b4b98a7af1e3565247
User: Max Prilutskiy (max@lingo.dev)

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@maxprilutskiy maxprilutskiy merged commit 62d3916 into main May 3, 2025
2 checks passed
@maxprilutskiy maxprilutskiy deleted the devin/1746241145-fix-php-sdk-validation branch May 3, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant