Skip to content

fix: update namespace case in PHP SDK tests to match class definition#733

Merged
maxprilutskiy merged 1 commit intomainfrom
devin/1746241750-fix-php-sdk-namespace
May 3, 2025
Merged

fix: update namespace case in PHP SDK tests to match class definition#733
maxprilutskiy merged 1 commit intomainfrom
devin/1746241750-fix-php-sdk-namespace

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Fix PHP SDK Namespace Case Mismatch

Problem

The PHP SDK publishing workflow was failing at the test step because of a namespace case mismatch between the test file and the class file. The test was using Lingodotdev\Sdk\LingoDotDevEngine while the actual class is defined as LingoDotDev\Sdk\LingoDotDevEngine.

Solution

Updated the namespace in the test file to match the case of the actual class definition.

This fix ensures that the PHP SDK tests can run successfully and the publishing workflow can complete without errors.

Testing

Verified locally that the fix resolves the issue by:

  1. Running composer validate --no-check-publish
  2. Running composer install --prefer-dist
  3. Running vendor/bin/phpunit php/sdk/tests/

All tests now pass successfully.

Link to Devin run: https://app.devin.ai/sessions/6407d462e80c47b4b98a7af1e3565247
User: Max Prilutskiy (max@lingo.dev)

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@maxprilutskiy maxprilutskiy merged commit d4138b2 into main May 3, 2025
2 checks passed
@maxprilutskiy maxprilutskiy deleted the devin/1746241750-fix-php-sdk-namespace branch May 3, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant