Skip to content

Fix: PHP SDK Deprecation Warnings and API Implementation#4

Merged
maxprilutskiy merged 1 commit intomainfrom
devin/1746253819-fix-deprecation-warnings
May 3, 2025
Merged

Fix: PHP SDK Deprecation Warnings and API Implementation#4
maxprilutskiy merged 1 commit intomainfrom
devin/1746253819-fix-deprecation-warnings

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Fix PHP SDK Deprecation Warnings and API Implementation

This PR addresses the deprecation warnings in the PHP SDK and improves the API implementation to match the JS SDK structure.

Changes

  • Fixed deprecation warnings about implicit nullable parameters by using explicit nullable types (?callable instead of callable = null)
  • Improved error handling for API requests with better error messages
  • Enhanced parameter validation for all methods
  • Updated API request format to match the JS SDK implementation
  • Improved progress callback handling
  • Added validation for reference parameter format

Testing

These changes have been tested with the PHP SDK demo and ensure that:

  • No deprecation warnings are shown when using the SDK
  • API requests are properly formatted to match the JS SDK implementation
  • Error handling is improved with more descriptive error messages

Link to Devin run: https://app.devin.ai/sessions/7e5ae8c97d464b8480760363c72c0712
Requested by: Max Prilutskiy (max@lingo.dev)

…mentation

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@maxprilutskiy maxprilutskiy merged commit 2334beb into main May 3, 2025
@maxprilutskiy maxprilutskiy deleted the devin/1746253819-fix-deprecation-warnings branch May 3, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant