fix: make CI toolchain tests fatal and add post-release smoke tests (issue #62)#63
Merged
fix: make CI toolchain tests fatal and add post-release smoke tests (issue #62)#63
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #62
…issue #62) Previously, all toolchain test commands in `docker-build-test` used `|| echo "test failed"` patterns, making every failure non-fatal. An image where cargo, python, go, or any tool was missing would still pass CI and be released. - Add `set -e` to all test steps so any failed command fails the CI job - Remove all non-fatal `|| echo "..."` fallback patterns from test commands - Add comprehensive toolchain tests covering all installed runtimes: cargo, rustup (Rust), pip3, python3 (Python via pyenv), gem, ruby (Ruby via rbenv), kotlin (JVM via SDKMAN), swift, dotnet, Rscript (R) - Add post-release smoke tests in `docker-build-push` job that validate the actually-published image after every main/dispatch release - Add case study docs in `docs/case-studies/issue-62/` with root cause analysis (Cyrillic 'с' vs ASCII 'c', NVM shell function behavior, non-fatal CI test patterns) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
konard
changed the title
konard/sandbox:1.3.13 image does not contain rust toolchain or it is not properly initializedThis reverts commit ad02b51.
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
Member
Author
✅ Ready to mergeThis pull request is now ready to be merged:
Monitored by hive-mind with --auto-restart-until-mergeable flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CI/CD quality gap reported in issue #62 where toolchain failures (cargo, python, go, etc.) did not actually fail the build, and adds post-release smoke tests to validate published images.
Root cause analysis (see
docs/case-studies/issue-62/CASE-STUDY.md):Cyrillic 'с' vs ASCII 'c': The
сargocommand in the issue used Unicode U+0441 Cyrillic 'с' instead of ASCII 'c' — a keyboard layout typo. This confirms the shell invocation by the--isolated dockerrunner uses/bin/sh, bypassing.bashrc.NVM is a shell function:
nvmis not a binary — it's a bash shell function. It can only be invoked after sourcing$NVM_DIR/nvm.sh. This is expected behavior;nodeitself (a binary) is accessible via PATH after the entrypoint runs.CI tests were non-fatal: All test commands used
|| echo "test failed"patterns, meaning a broken image would still be released with CI showing "passed".Changes
set -eto all test steps; removed all|| echo "..."non-fatal fallbackscargo,rustup(Rust)python3,pip3(Python via pyenv)ruby,gem(Ruby via rbenv)kotlin(JVM via SDKMAN)swift,dotnet,Rscript(R)docker-build-pushjob that validates the actually-published image (not just locally built), covering all toolchainsdocs/case-studies/issue-62/with full root cause analysis, timeline, and CI log from the 1.3.13 releaseTest plan
docker-build-test) now fails if any toolchain is missing🤖 Generated with Claude Code
Fixes #62