feat: adding TagDiscovery panel feature (#494)#500
feat: adding TagDiscovery panel feature (#494)#500EmanuelGF wants to merge 2 commits intolinkdotnet:masterfrom
Conversation
|
Hey @EmanuelGF, thanks for filing the PR. We are off to a good start, there are some rough edges to iron out: It seems the padding vertically seems a bit off. Horizontally is also off, if you switch to responsive/mobile: |
tests/LinkDotNet.Blog.UnitTests/Web/Features/Services/Tags/TagQueryServiceTests.cs
Outdated
Show resolved
Hide resolved
src/LinkDotNet.Blog.Web/Features/Services/Tags/TagQueryService.cs
Outdated
Show resolved
Hide resolved
src/LinkDotNet.Blog.Web/Features/TagDiscovery/TagDiscoveryPanel.razor
Outdated
Show resolved
Hide resolved
src/LinkDotNet.Blog.Web/Features/TagDiscovery/TagDiscoveryPanel.razor.css
Show resolved
Hide resolved
|
Greetings! Have a great week!! |
|
Thanks for taking this on @EmanuelGF. Thoughts on also having the tag component being optionally shown in other places independent of the toggle in the nav bar? (Page footer, above posts list, archive page...) |
|
If everything more or less set in stone we need to extend the migrator to convert the appsettings.json files for folks. |
That is a good question - I would probably have it in one place and one place only mainly because it isn’t „essential“ for the blog itself. Whether or not that is the navbar is up to discussion. I was also thinking of remodelling the navbar as there are quite some entries now. I fear if put „just“ the tag icon that might be not enough and with text and a bit of zoom it has to wrap to the next row. |
|
@EmanuelGF also ping me once you have the updated changes ready, happy to review this as well |
|
Greetings!! |
|
Great work @EmanuelGF! Code looks good but a few things to consider:
I tested these on Google Chrome |




This PR introduces a new TagDiscovery feature discussed in issue #494 allowing users to discover blog topics via a tag discovery panel accessible from the navigation bar.