Skip to content

Conversation

@varunu28
Copy link
Collaborator

Changes:

  • Added StringBuilder Reverse functionality
  • Added tests to verify correctness of Reverse functionality
  • Added tests to verify reuse of reversed string builder

This is to address the feature request discussed under #4

@varunu28 varunu28 requested a review from linkdotnet August 26, 2023 20:36
@linkdotnet
Copy link
Owner

Changes are looking good @varunu28

One thought we might wanna keep in mind for the future (or even v1): Right now the StringBuilder does not support Unicode characters (like emojis) - everything that consists of multiple runes.

@varunu28
Copy link
Collaborator Author

Changes are looking good @varunu28

One thought we might wanna keep in mind for the future (or even v1): Right now the StringBuilder does not support Unicode characters (like emojis) - everything that consists of multiple runes.

Oh thanks for that callout. That will definitely require some amount of redesign for how we are currently storing contents of string builder.

@varunu28 varunu28 merged commit a8b58b6 into main Aug 26, 2023
@varunu28 varunu28 deleted the reverse-stringbuilder branch August 26, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants