Skip to content

Spawn Trigger Jobs With Owner Reference#204

Merged
srnand merged 1 commit intomainfrom
sthakkar/apr01_26/addOwnerReference
Apr 2, 2026
Merged

Spawn Trigger Jobs With Owner Reference#204
srnand merged 1 commit intomainfrom
sthakkar/apr01_26/addOwnerReference

Conversation

@srnand
Copy link
Copy Markdown
Collaborator

@srnand srnand commented Apr 2, 2026

Summary

  • Spawn jobs initiated by TableTriggers with correct owner references to ensure clean cascading deletion when a TableTrigger is dropped.

Test

0: Hoptimator> CREATE TRIGGER dummy_retl_trigger ON ads.ad_clicks AS 'retl-job-template' IN 'default' WITH ('offline.table.name' 'my-namespace.my-table','job.properties.online.table.name' 'MyOnlineTable');
INFO Validating statement: CREATE TRIGGER `DUMMY_RETL_TRIGGER` ON `ADS`.`AD_CLICKS` AS 'retl-job-template' IN 'default' WITH ('offline.table.name', 'my-namespace.my-table', 'job.properties.online.table.name', 'MyOnlineTable')
INFO Validating trigger DUMMY_RETL_TRIGGER with deployers
INFO Validated trigger DUMMY_RETL_TRIGGER
INFO Creating trigger DUMMY_RETL_TRIGGER
INFO Successfully snapshot K8s obj: TableTrigger:dummyretltrigger
INFO Created K8s obj: TableTrigger:dummyretltrigger
INFO Deployed trigger DUMMY_RETL_TRIGGER
INFO CREATE TRIGGER DUMMY_RETL_TRIGGER completed
No rows affected (0.317 seconds)
➜  Hoptimator git:(sthakkar/apr01_26/addOwnerReference) ✗ k get jobs dummyretltrigger-retl-job-template-job -oyaml
apiVersion: batch/v1
kind: Job
metadata:
  annotations:
    trigger: dummyretltrigger
    triggerTimestamp: "2026-04-02T01:26:26Z"
  creationTimestamp: "2026-04-02T01:26:26Z"
  generation: 1
  labels:
    trigger: dummyretltrigger
  name: dummyretltrigger-retl-job-template-job
  namespace: default
  ownerReferences:
  - apiVersion: hoptimator.linkedin.com/v1alpha1
    kind: TableTrigger
    name: dummyretltrigger
    uid: 8526b8e2-fd43-409a-9716-7e61132c3583
  resourceVersion: "413127"
  uid: ad7b7352-2a4a-4a3b-84fc-bcf186c48dc8
spec:
...

@srnand srnand requested a review from ryannedolan April 2, 2026 01:30
Copy link
Copy Markdown
Collaborator

@ryannedolan ryannedolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@srnand srnand merged commit 51f1ba0 into main Apr 2, 2026
1 check passed
@srnand srnand deleted the sthakkar/apr01_26/addOwnerReference branch April 2, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants